-
-
Notifications
You must be signed in to change notification settings - Fork 0
Follow README instructions for converting from the template #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe pull request renames the extension from "paranext-extension-template" to "interlinearizer" across config, docs, type declarations, and runtime log messages; updates publisher/author metadata; adds manifest entries for localizedStrings, themes, and activationEvents; and updates display and description assets. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@README.md`:
- Around line 3-5: Update the README title string from "# interlinearizer" to "#
Interlinearizer" to match the project's branding; edit the top-level heading in
README.md so the capitalized title "Interlinearizer" is used consistently across
docs.
- Line 7: The README contains a nested HTML comment token ("<!-- <!--") that can
confuse renderers; update the Template Info opening comment so it uses a single
opening HTML comment token ("<!--") only, preserving the rest of the comment
text and surrounding markup (look for the line starting with the duplicated
"<!-- <!--" in the README and replace it with a single "<!--" to remove the
nested token).
🧹 Nitpick comments (1)
assets/descriptions/description-en.md (1)
1-3: Drop build-tooling details from the user-facing description.
Consider removing “Powered by webpack” so the description focuses on user value.🧹 Proposed tweak
-Interlinearizer extension for Platform.Bible. Powered by webpack. +Interlinearizer extension for Platform.Bible.
jasonleenaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonleenaylor partially reviewed 9 files and all commit messages, and made 2 comments.
Reviewable status: 9 of 10 files reviewed, all discussions resolved (waiting on @imnasnainaec).
README.md line 7 at r2 (raw file):
Interlinearizer extension for Platform.Bible <!-- <!-- Opening comment tag for Template Info Section. Ignore this for now. More info in [Hide Template Info](#hide-template-info).
this could/should be removed also
README.md line 83 at r2 (raw file):
#### Hide Template Info Once finished customizing this template to be your own, you can uncomment the [HTML comment tag](https://www.w3schools.com/html/html_comments.asp) above the [Template Info](#template-info) section to hide this template-related info in this readme. You can do this by clicking on the line and doing CTRL + / in VS Code. You can also do this manually by removing the first opening '<!--' and the only closing '-->' on the line. Leaving this info commented in your readme will hide it in your readme while avoiding merge conflicts if you decide to [update this extension from the template](#to-update-this-extension-from-the-template) in the future. If you never want to update this extension from the template, you can remove the [Template Info](#template-info) section and sub-sections of this readme.
as suggested
jasonleenaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonleenaylor reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec).
Resolves #3
This change is
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.