Skip to content

[gha] Limit npm ci; Add :coverage to test#80

Merged
imnasnainaec merged 3 commits into
mainfrom
test-coverage
May 21, 2026
Merged

[gha] Limit npm ci; Add :coverage to test#80
imnasnainaec merged 3 commits into
mainfrom
test-coverage

Conversation

@imnasnainaec
Copy link
Copy Markdown
Contributor

@imnasnainaec imnasnainaec commented May 21, 2026

Resolves #41


This change is Reviewable

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflows across version bumping, linting, publishing, and testing processes for optimized dependency management.

Review Change Stack

@imnasnainaec imnasnainaec self-assigned this May 21, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Warning

Rate limit exceeded

@imnasnainaec has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 55 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 257ae09c-3329-4154-950c-8ebe73a6ddc9

📥 Commits

Reviewing files that changed from the base of the PR and between ae27d45 and cb79a62.

📒 Files selected for processing (2)
  • .github/workflows/publish.yml
  • .github/workflows/test.yml
📝 Walkthrough

Walkthrough

Four GitHub Actions workflows are updated to standardize npm dependency installation by adding --ignore-scripts and --omit=optional flags to all npm ci commands. The test workflow is additionally modified to run npm test:coverage instead of npm test.

Changes

CI/CD Workflow Standardization

Layer / File(s) Summary
Standardize npm ci flags across workflows
.github/workflows/bump-versions.yml, .github/workflows/lint.yml, .github/workflows/publish.yml, .github/workflows/test.yml
All workflows now install dependencies with npm ci --ignore-scripts --omit=optional to skip optional packages and lifecycle scripts consistently. The test workflow also switches from npm test to npm test:coverage to report coverage metrics.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A workflow so neat, workflows unified in pace,
--ignore-scripts and --omit find their place,
Coverage runs true with the test suite so bright,
CI machines march forward with standardized might! 🚀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: limiting npm ci flags and adding coverage to tests, matching the primary modifications across four workflow files.
Linked Issues check ✅ Passed The PR adds coverage reporting via npm test:coverage in the test workflow, directly addressing issue #41's requirement to enforce 100% test coverage.
Out of Scope Changes check ✅ Passed All changes are scoped to npm installation flags and test coverage configuration, directly supporting the test coverage enforcement objective without unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test-coverage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@alex-rawlings-yyc alex-rawlings-yyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-rawlings-yyc reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

Copy link
Copy Markdown
Contributor Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imnasnainaec reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

@imnasnainaec imnasnainaec merged commit 5dcab20 into main May 21, 2026
8 checks passed
@imnasnainaec imnasnainaec deleted the test-coverage branch May 21, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce 100% test coverage

2 participants