Skip to content

Prevent partial project creation #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

Prevent partial project creation #2012

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
387f806
Delete draft projects as part of the project-create transaction
myieye Sep 22, 2025
a50899a
Clean up created repo if project-create fails
myieye Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions backend/LexBoxApi/Services/ProjectService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,21 +52,33 @@ public async Task<Guid> CreateProject(CreateProjectInput input)
FlexProjectMetadata = input.Type == ProjectType.FLEx ? new() : null
});
// Also delete draft project, if any
await dbContext.DraftProjects.Where(dp => dp.Id == projectId).ExecuteDeleteAsync();
if (draftProject is not null)
{
dbContext.DraftProjects.Remove(draftProject);
}

var manager = input.ProjectManagerId.HasValue ? await dbContext.Users.FindAsync(input.ProjectManagerId.Value) : null;
manager?.UpdateCreateProjectsPermission(ProjectRole.Manager);

await dbContext.SaveChangesAsync();
await hgService.InitRepo(input.Code);
InvalidateProjectOrgIdsCache(projectId);
InvalidateProjectConfidentialityCache(projectId);
InvalidateProjectCodeCache(input.Code);
try
{
await hgService.InitRepo(input.Code);
InvalidateProjectOrgIdsCache(projectId);
InvalidateProjectConfidentialityCache(projectId);
InvalidateProjectCodeCache(input.Code);
await transaction.CommitAsync();
}
catch
{
// CommitAsync() did not run [successfully], so we don't want a repo to exist
await hgService.DeleteRepo(input.Code);
throw;
}
if (draftProject != null && manager != null)
{
await emailService.SendApproveProjectRequestEmail(manager, input);
}
await transaction.CommitAsync();
return projectId;
}

Expand Down
Loading