Merge feature/nuget into develop#191
Merged
ermshiperete merged 62 commits intosillsdev:developfrom Oct 1, 2021
ermshiperete:develop
Merged
Merge feature/nuget into develop#191ermshiperete merged 62 commits intosillsdev:developfrom ermshiperete:develop
feature/nuget into develop#191ermshiperete merged 62 commits intosillsdev:developfrom
ermshiperete:develop
Conversation
ICU_DATA should point to the directory that contains nf*c_fw.nrm. Previously we set it to the parent directory, so the tests only worked if the environment variable or registry key was set.
The .props file adds the msbuild tasks, making it easier to use them.
Since this is a tools project that runs during client build time we have to include all dependencies in the nuget package.
Also improves error message in case deserializing of XML file fails, and fixes rebuilding SIL.LCModel.Core.
Also make SIL.LCModel.Tests packable
Also remove warning about files specified multiple times.
Also fix package paths.
This allows to specify location for HandGenerated.xml and IntPropTypeOverrides.xml.
This change includes HandGenerated.xml and IntPropTypeOverrides.xml in the nuget package.
This change prevents the dlls from Icu4c.Win.Min to automatically get copied to the output directory when a client consumes the SIL.LCModel.Core.Tests nuget package.
…a-version Updated to use latest beta versions of libpalaso DLLs
* Always use the latest SIL NuGet packages, now including *Tasks and IdlImporter * Copy packages to the local nuget repository after packing, if the local nuget repo is specified * Remove an unused argument from the build scripts
+semver:minor
(This is mainly a change to force a new version number so that the new nuget version includes dependencies on the latest libpalaso version. Since we use wildcards in the package reference to libpalaso packages and since there hasn't been a new release of libpalaso (only new beta version), we can't change anything related to libpalso nuget package version in here that would give us dependencies on the new version.)
* Copy the icu library files into the output directory
* Mark the Icu4c.Win.Fw.Lib runtime as private to avoid an unwanted copy by projects that depend on SIL.LCModel.Core * Fix problem with VS locking the SIL.LCModel.Build.Tasks and blocking all builds but the first
+semver:major
The `CreateNewLangProject_AnthropologyCategoriesExist` test failed on Linux because the time of the last write we stored in `m_lastWriteTime` was a few ticks off of the value we got from file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fast-forward from
feature/nugetwith one additional commit.This change is