Fix LT-21206: Features label misleading: "Show Abbr as label" #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonleenaylor
approved these changes
Mar 7, 2025
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of https://jira.sil.org/browse/LT-21206, Beth requested that "On the Values, please change the functionality [of Show Abbreviation as Label] to allow it to show either the Name or the Abbreviation. (I need to research whether a user might not want the value itself to show at all)". I checked with Beth, and she hasn't done the research but wants to go ahead with this change and add an option later if somebody asks for it.
So, I changed GetValueString to use Name if ValueRA.ShowInGloss is false.
This should be part of release/9.3.
This change is