Skip to content

Fix LT-22205: Consider combining <field> and <field> (Allomorph) #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

Fix LT-22205: Consider combining <field> and <field> (Allomorph) #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/SIL.LCModel/DomainImpl/OverridesLing_Lex.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,7 @@ public IEnumerable<ICmObject> AllPossiblePictures

/// <summary>
/// Gets all the bulk-editable things that might be used as the destination of a bulk edit to
/// Allomorphs. This includes the entries that do not have allomorphs. It does NOT include
/// MoForms that are the LexemeForm of some entry. (Possibly the name should indicate this better somehow?)
/// Allomorphs. This includes MoForms that are the LexemeForm of some entry.
/// </summary>
[VirtualProperty(CellarPropertyType.ReferenceSequence, "CmObject")]
public IEnumerable<ICmObject> AllPossibleAllomorphs
Expand All @@ -217,9 +216,7 @@ public IEnumerable<ICmObject> AllPossibleAllomorphs
// Optimize JohnT: are we likely to modify any of the iterators while iterating? If not
// we may not need the ToList().
return (from entry in entries from morph in entry.AlternateFormsOS select morph).Cast<ICmObject>()
.Concat((from entry in entries
where entry.AlternateFormsOS.Count == 0
select entry).Cast<ICmObject>())
.Concat((from entry in entries select entry.LexemeFormOA).Cast<ICmObject>())
.ToList();
}
}
Expand Down
Loading