Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Dec 4, 2025

A part of sillsdev/serval#805.

This stores the times that each phase starts as a user property for retrieval by Serval.

For example:
image


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.77%. Comparing base (423f81d) to head (1f932d2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files         352      352           
  Lines       22290    22294    +4     
=======================================
+ Hits        20234    20238    +4     
  Misses       2056     2056           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: (Rerunning the CI builds that failed. Sometimes they're running out of space the last couple weeks, but usually succeed when re-run.)

@Enkidu93 reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@pmachapman pmachapman requested a review from ddaspit December 4, 2025 19:18
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@pmachapman pmachapman force-pushed the report_phase_started branch from 187e31d to 1f932d2 Compare December 7, 2025 18:06
@pmachapman pmachapman merged commit 2ff2a03 into main Dec 7, 2025
171 of 196 checks passed
@pmachapman pmachapman deleted the report_phase_started branch December 7, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants