Fixes #130

[Enkidu93]

This change is 

[codecov-commenter]

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
...NetCore/Configuration/IMachineBuilderExtensions.cs	0.00% <0.00%> (ø)
...ine.AspNetCore/Services/CancellationInterceptor.cs	0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!

[ddaspit]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

---

src/SIL.Machine.AspNetCore/Services/CancellationInterceptor.cs line 27 at r1 (raw file):

            {
                _logger.LogInformation(exception: ex, message: null);
                return null;

Does this mean that the gRPC endpoint won't return a CANCELLED status code?

[Enkidu93]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

src/SIL.Machine.AspNetCore/Services/CancellationInterceptor.cs line 27 at r1 (raw file):

            {
                _logger.LogInformation(exception: ex, message: null);
                return null;

Does this mean that the gRPC endpoint won't return a CANCELLED status code?

Before:

After:

It returns a cancelled status code (which is wasn't before) and gets filtered on the other end. The notable difference is that it is logged as info rather than an failure.

[johnml1135]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)

[ddaspit]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

---

src/SIL.Machine.AspNetCore/Services/CancellationInterceptor.cs line 26 at r1 (raw file):

            if (ex is OperationCanceledException)
            {
                _logger.LogInformation(exception: ex, message: null);

Do we need to log this at all?

---

src/SIL.Machine.AspNetCore/Services/CancellationInterceptor.cs line 27 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

Before:

After:

It returns a cancelled status code (which is wasn't before) and gets filtered on the other end. The notable difference is that it is logged as info rather than an failure.

Ok, good.

[Enkidu93]

src/SIL.Machine.AspNetCore/Services/CancellationInterceptor.cs line 26 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Do we need to log this at all?

@johnml1135 , you're the one who asked for it to be moved to info. Do you want this logged at all? A lower log level than info? Just ignore it?

[johnml1135]

src/SIL.Machine.AspNetCore/Services/CancellationInterceptor.cs line 26 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

@johnml1135 , you're the one who asked for it to be moved to info. Do you want this logged at all? A lower log level than info? Just ignore it?

Probably instead of printing the whole exception, we can just say "this job was cancelled." So we can know that the cancellation signal was successful. Info is fine - I don't need a stack trace though.

[ddaspit]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)

---

src/SIL.Machine.AspNetCore/Services/CancellationInterceptor.cs line 26 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Probably instead of printing the whole exception, we can just say "this job was cancelled." So we can know that the cancellation signal was successful. Info is fine - I don't need a stack trace though.

Sounds good to me.

[Enkidu93]

src/SIL.Machine.AspNetCore/Services/CancellationInterceptor.cs line 26 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Sounds good to me.

Done.

[ddaspit]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

[johnml1135]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)