LT-22353: Change Hermit Crab to allow merge and split rules #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22353. We want to add merge rules (2 -> 1) and split rules (1 -> 2) in the phonology. It turns out that NarrowAnalysisRewriteRuleSpec implemented merge rules, but the code had never been tested and there was a bug when the right hand side had anything in it. I added unit tests and fixed the bug. It also turned out that NarrowAnalysisRewriteRuleSpec worked for expanding as well as narrowing, so I added unit tests for expanding and code to use NarrowAnalysisRewriteRuleSpec in this case. There is no need to test for an infinite loop (see EpenthesisSynthesisRewriteSubruleSpec) when expanding since a rule cannot apply to its own output.
This change is