Skip to content

Fix LT-22480: Merge rule bug#403

Merged
jtmaxwell3 merged 2 commits intomasterfrom
LT-22480
Apr 10, 2026
Merged

Fix LT-22480: Merge rule bug#403
jtmaxwell3 merged 2 commits intomasterfrom
LT-22480

Conversation

@jtmaxwell3
Copy link
Copy Markdown
Collaborator

@jtmaxwell3 jtmaxwell3 commented Apr 9, 2026

This fixes https://jira.sil.org/browse/LT-22480. When deleting nodes, it should skip over the nodes that have already been deleted.


This change is Reviewable

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.00%. Comparing base (8bf4e47) to head (74d725f).

Files with missing lines Patch % Lines
...ologicalRules/NarrowSynthesisRewriteSubruleSpec.cs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   73.00%   73.00%           
=======================================
  Files         439      439           
  Lines       36685    36693    +8     
  Branches     5036     5038    +2     
=======================================
+ Hits        26782    26789    +7     
- Misses       8788     8789    +1     
  Partials     1115     1115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93 Enkidu93 requested a review from ddaspit April 9, 2026 18:34
Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on jtmaxwell3).

@jtmaxwell3 jtmaxwell3 merged commit 812aa48 into master Apr 10, 2026
4 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-22480 branch April 10, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants