Skip to content

Add support for per-chapter remarks#408

Open
pmachapman wants to merge 1 commit intomasterfrom
per_chapter_remarks
Open

Add support for per-chapter remarks#408
pmachapman wants to merge 1 commit intomasterfrom
per_chapter_remarks

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented Apr 16, 2026

Part of sillsdev/serval#905


This change is Reviewable

@pmachapman pmachapman requested review from Enkidu93 and ddaspit April 16, 2026 02:41
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.04%. Comparing base (a272952) to head (fc18cf3).

Files with missing lines Patch % Lines
src/SIL.Machine/Corpora/UpdateUsfmParserHandler.cs 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   73.02%   73.04%   +0.02%     
==========================================
  Files         439      439              
  Lines       36693    36721      +28     
  Branches     5039     5045       +6     
==========================================
+ Hits        26794    26822      +28     
  Misses       8787     8787              
  Partials     1112     1112              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work relate to this PR Matthew is working on: sillsdev/machine.py#285?

@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).


src/SIL.Machine/Corpora/UpdateUsfmParserHandler.cs line 468 at r1 (raw file):

                        {
                            // Add the remarks just after the specified chapter,
                            // skipping any alternate and published chapter numbers

Unless I'm missing something, I don't think this will skip \ca and \cp markers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants