Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #408 +/- ##
==========================================
+ Coverage 73.02% 73.04% +0.02%
==========================================
Files 439 439
Lines 36693 36721 +28
Branches 5039 5045 +6
==========================================
+ Hits 26794 26822 +28
Misses 8787 8787
Partials 1112 1112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enkidu93
left a comment
There was a problem hiding this comment.
How does this work relate to this PR Matthew is working on: sillsdev/machine.py#285?
@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ddaspit).
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).
src/SIL.Machine/Corpora/UpdateUsfmParserHandler.cs line 468 at r1 (raw file):
{ // Add the remarks just after the specified chapter, // skipping any alternate and published chapter numbers
Unless I'm missing something, I don't think this will skip \ca and \cp markers.
Part of sillsdev/serval#905
This change is