Skip to content

So we don't pretranslate everything#519

Merged
johnml1135 merged 2 commits intomainfrom
sf_test_fix
Oct 24, 2024
Merged

So we don't pretranslate everything#519
johnml1135 merged 2 commits intomainfrom
sf_test_fix

Conversation

@johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Oct 23, 2024

This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit October 23, 2024 19:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.67%. Comparing base (bdf43fa) to head (87388c5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage   56.67%   56.67%           
=======================================
  Files         299      299           
  Lines       15626    15627    +1     
  Branches     2154     2155    +1     
=======================================
+ Hits         8856     8857    +1     
  Misses       6114     6114           
  Partials      656      656           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit 0b06fbf into main Oct 24, 2024
@johnml1135 johnml1135 deleted the sf_test_fix branch October 24, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants