Conversation
* ignore CS0612 obsolete endpoint warnings in E2E and integration tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
=======================================
Coverage 56.95% 56.95%
=======================================
Files 299 299
Lines 15734 15734
Branches 2173 2173
=======================================
Hits 8962 8962
Misses 6122 6122
Partials 650 650 ☔ View full report in Codecov by Sentry. |
ddaspit
left a comment
There was a problem hiding this comment.
We should also mark obsolete properties in the relevant DTOs.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
|
Done |
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)
src/Serval/test/Serval.ApiServer.IntegrationTests/Serval.ApiServer.IntegrationTests.csproj line 16 at r2 (raw file):
<TreatWarningsAsErrors>true</TreatWarningsAsErrors> <GenerateDocumentationFile>true</GenerateDocumentationFile> <NoWarn>$(NoWarn);CS1591;CS1573;CS0612</NoWarn>
We should use #pragma warning disable CS0612 like you did in the controller.
|
Previously, ddaspit (Damien Daspit) wrote…
done |
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
Resolves #515
This change is