Conversation
|
Should this be a tuple rather than a concatenated string? |
johnml1135
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93)
Enkidu93
left a comment
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @johnml1135)
src/ServiceToolkit/src/SIL.ServiceToolkit/Services/ParallelCorpusPreprocessingService.cs line 105 at r1 (raw file):
Previously, johnml1135 (John Lambert) wrote…
Should this be a tuple rather than a concatenated string?
I went ahead and switched it. I'm not sure what's most efficient under the hood.
|
Previously, Enkidu93 (Eli C. Lowry) wrote…
It was more about the off chance that there could be a conflict where there would be "hello world " + "day" and "hello " + "world day". Not likely, but the tuple solution appears cleaner to me. |
johnml1135
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ddaspit)
Fixes #538
This change is