Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
==========================================
+ Coverage 61.31% 62.89% +1.57%
==========================================
Files 275 279 +4
Lines 13731 13959 +228
Branches 1793 1811 +18
==========================================
+ Hits 8419 8779 +360
+ Misses 4716 4557 -159
- Partials 596 623 +27 ☔ View full report in Codecov by Sentry. |
5b1d67d to
de529ce
Compare
Enkidu93
left a comment
There was a problem hiding this comment.
Reviewed 25 of 25 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ddaspit)
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed 16 of 25 files at r1, 11 of 13 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @johnml1135)
src/Serval/src/Serval.DataFiles/Services/CorpusService.cs line 6 at r4 (raw file):
IRepository<Corpus> corpora, IDataAccessContext dataAccessContext, IDataFileService dataFileService,
We usually just use the repositories directly in entity services.
src/Serval/src/Serval.DataFiles/Services/CorpusService.cs line 47 at r4 (raw file):
{ TextId = f.TextId!, File = Map(await _dataFileService.GetAsync(f.FileId))
You can retrieve all of the data files in a single query.
src/Serval/src/Serval.DataFiles/Models/CorpusFile.cs line 5 at r4 (raw file):
public record CorpusFile { public required string FileId { get; init; }
The convention when a property is a foreign key reference is to suffix with Ref instead of Id, i.e. FileRef.
src/Serval/src/Serval.DataFiles/Consumers/GetCorpusConsumer.cs line 27 at r4 (raw file):
{ TextId = f.TextId!, File = Map(await _dataFileService.GetAsync(f.FileId))
You can retrieve all of the data files in a single query.
src/Serval/src/Serval.DataFiles/Contracts/CorpusFileDto.cs line 5 at r4 (raw file):
public record CorpusFileDto { public required string FileId { get; init; }
This should be called File and be a ResourceLinkDto.
johnml1135
left a comment
There was a problem hiding this comment.
Reviewed 11 of 13 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @johnml1135)
|
Damien made updates to address the concerns he had. |
Resolves #547
Sync corpora and data files in translation engine
Make DataFile Corpuses only have a link to the DataFile
Fix ParallelCorpus Delete CorpusFile
Use mongoDB strings directly for Mongo array filtering (hacky solution - need to fix later #553).
Broken implementation for MemoryRepository - #554
This change is