Don't crash if retrieving a corpora with a blank language code#600
Merged
johnml1135 merged 1 commit intomainfrom Jan 13, 2025
Merged
Don't crash if retrieving a corpora with a blank language code#600johnml1135 merged 1 commit intomainfrom
johnml1135 merged 1 commit intomainfrom
Conversation
Enkidu93
approved these changes
Jan 13, 2025
Collaborator
Enkidu93
left a comment
Enkidu93
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @johnml1135)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 64.48% 64.48%
=======================================
Files 280 280
Lines 14105 14105
Branches 1825 1825
=======================================
Hits 9095 9095
Misses 4349 4349
Partials 661 661 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further fix for #595
This change is