I can't believe we missed this.

[johnml1135]

This change is 

[ddaspit]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

---

a discussion (no related file):
We are intentionally not deleting files. Deleting resources on a web API with asynchronous processes is a tricky thing. Deleting a file while it is currently being used by a build can cause unexpected behavior, so we purposefully wait to delete the file. The DeletedFileCleaner class is responsible for actually deleting the file.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.68%. Comparing base (8e7f367) to head (a168a30).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##            main     #647       +/-   ##
==========================================
+ Coverage   0.00%   64.68%   +64.68%     
==========================================
  Files        342      342               
  Lines      18704    18705        +1     
  Branches    2427     2427               
==========================================
+ Hits           0    12099    +12099     
+ Misses     18704     5729    -12975     
- Partials       0      877      +877     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[johnml1135]

Previously, ddaspit (Damien Daspit) wrote…

We are intentionally not deleting files. Deleting resources on a web API with asynchronous processes is a tricky thing. Deleting a file while it is currently being used by a build can cause unexpected behavior, so we purposefully wait to delete the file. The DeletedFileCleaner class is responsible for actually deleting the file.

Changed to an explanatory note. The next person will not think it's a bug then :-)

[ddaspit]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

---

a discussion (no related file):

Previously, johnml1135 (John Lambert) wrote…

Changed to an explanatory note. The next person will not think it's a bug then :-)

Are deleted files not getting cleaned up?

[johnml1135]

Previously, ddaspit (Damien Daspit) wrote…

Are deleted files not getting cleaned up?

I didn't give it 24 hours - just 12. I'll check again to make sure they actually got removed.

[johnml1135]

Previously, johnml1135 (John Lambert) wrote…

I didn't give it 24 hours - just 12. I'll check again to make sure they actually got removed.

Verified it - they did delete after 24 hours. I would still like to add this comment though, to help the next person.