Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
- Coverage 66.25% 66.23% -0.02%
==========================================
Files 364 364
Lines 19393 19415 +22
Branches 2486 2491 +5
==========================================
+ Hits 12849 12860 +11
- Misses 5636 5647 +11
Partials 908 908 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed 24 of 24 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)
src/DataAccess/src/SIL.DataAccess/IServiceCollectionExtensions.cs line 38 at r1 (raw file):
var clientSettings = MongoClientSettings.FromConnectionString(connectionString); clientSettings.ClusterConfigurator = cb => cb.Subscribe(new DiagnosticsActivityEventSubscriber()); clientSettings.LinqProvider = LinqProvider.V2;
Yay! I've been wanting to spend the time to get it to work with V3 for a long time.
src/Serval/src/Serval.Translation/Services/EngineService.cs line 486 at r1 (raw file):
{ if (sourceFiles is not null) u.Set(c => c.Corpora.FirstMatchingElement().SourceFiles, sourceFiles);
I would like to keep the DataAccess library decoupled from Mongo. We should use something defined by the DataAccess library instead of a function defined by the Mongo driver.
pmachapman
left a comment
There was a problem hiding this comment.
Reviewable status: 19 of 27 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93)
src/Serval/src/Serval.Translation/Services/EngineService.cs line 486 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
I would like to keep the DataAccess library decoupled from Mongo. We should use something defined by the DataAccess library instead of a function defined by the Mongo driver.
Done. I wasn't able to use the FieldDefinition as was done in the LINQ2 implementation (because pretty much all of the LINQ3 logic is in public static methods), but I was able to implement a ExpressionVisitor to rewrite the LINQ3 query before it is passed to the Mongo Driver's ExpressionFieldDefinition. Let me know of this approach is OK.
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @pmachapman)
src/Serval/src/Serval.Translation/Services/EngineService.cs line 486 at r1 (raw file):
Previously, pmachapman (Peter Chapman) wrote…
Done. I wasn't able to use the
FieldDefinitionas was done in the LINQ2 implementation (because pretty much all of the LINQ3 logic is inpublic staticmethods), but I was able to implement aExpressionVisitorto rewrite the LINQ3 query before it is passed to the Mongo Driver'sExpressionFieldDefinition. Let me know of this approach is OK.
This is a clever solution. I'm happy with it.
This PR updates the MongoDB Driver to 3.4, and Hangfire to 1.8.20, which provides full support for MongoDB 8.0. This PR will still function correctly on MongoDB 6.0 and 7.0, as no 8.0 specific features have been implemented.
This is a pre-requisite for the completion of #682.
This change is