Add update support to the echo translation engine#733
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
=======================================
Coverage 66.34% 66.34%
=======================================
Files 368 368
Lines 19652 19652
Branches 2510 2510
=======================================
Hits 13039 13039
Misses 5699 5699
Partials 914 914 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman)
src/Echo/src/EchoEngine/TranslationEngineServiceV1.cs line 48 at r1 (raw file):
if (request.SourceLanguage != request.TargetLanguage) { var status = new Status(StatusCode.InvalidArgument, "Source and target languages must be the same");
I was thinking that we might need to cover the case where the client only changes the source or target lang, but it looks like that's covered implicitly in the EngineService.
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman)
576b5f1 to
fdfeda0
Compare
Fixes #730
This change is