Skip to content

Add update support to the echo translation engine#733

Merged
Enkidu93 merged 1 commit intomainfrom
echo_update_support
Aug 21, 2025
Merged

Add update support to the echo translation engine#733
Enkidu93 merged 1 commit intomainfrom
echo_update_support

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Aug 20, 2025

Fixes #730


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.34%. Comparing base (01802f0) to head (fdfeda0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #733   +/-   ##
=======================================
  Coverage   66.34%   66.34%           
=======================================
  Files         368      368           
  Lines       19652    19652           
  Branches     2510     2510           
=======================================
  Hits        13039    13039           
  Misses       5699     5699           
  Partials      914      914           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks for doing this!

@Enkidu93 reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)


src/Echo/src/EchoEngine/TranslationEngineServiceV1.cs line 48 at r1 (raw file):

        if (request.SourceLanguage != request.TargetLanguage)
        {
            var status = new Status(StatusCode.InvalidArgument, "Source and target languages must be the same");

I was thinking that we might need to cover the case where the client only changes the source or target lang, but it looks like that's covered implicitly in the EngineService.

@Enkidu93 Enkidu93 requested a review from ddaspit August 20, 2025 19:18
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@Enkidu93 Enkidu93 force-pushed the echo_update_support branch from 576b5f1 to fdfeda0 Compare August 21, 2025 15:05
@Enkidu93 Enkidu93 merged commit a193cf4 into main Aug 21, 2025
3 checks passed
@Enkidu93 Enkidu93 deleted the echo_update_support branch August 21, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot update an echo translation engine

4 participants