Skip to content

Fix parent project look up logic#904

Merged
Enkidu93 merged 1 commit intomainfrom
fix_daughter_project_warning
Apr 17, 2026
Merged

Fix parent project look up logic#904
Enkidu93 merged 1 commit intomainfrom
fix_daughter_project_warning

Conversation

@Enkidu93
Copy link
Copy Markdown
Collaborator

@Enkidu93 Enkidu93 commented Apr 13, 2026

I don't know how I missed this! I think I got so caught up in the refactoring that I forgot to add rigorous tests for the most essential change 😵. Added tests to cover this case as well as a couple other things I noticed were not covered.

Fixes #903.

I did not de-duplicate the warnings since after thinking about it more, I wasn't sure if it'd be helpful to see whether this is affecting both SF parallel corpora or just one. Unlike duplicating the versification warnings which could become sizable, this would only ever be one extra message, so I don't know that it's worth it, but I'm open to changing my mind.


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit April 13, 2026 16:32
Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@Enkidu93 Enkidu93 force-pushed the fix_daughter_project_warning branch from 76a77e0 to e00267c Compare April 17, 2026 06:41
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.97%. Comparing base (714891c) to head (e00267c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
+ Coverage   67.87%   67.97%   +0.10%     
==========================================
  Files         386      386              
  Lines       21256    21253       -3     
  Branches     2749     2749              
==========================================
+ Hits        14427    14447      +20     
+ Misses       5844     5825      -19     
+ Partials      985      981       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Enkidu93 Enkidu93 merged commit 5f6389c into main Apr 17, 2026
2 checks passed
@Enkidu93 Enkidu93 deleted the fix_daughter_project_warning branch April 17, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daughter project support bug

3 participants