Skip to content

Refactor all remaining engine endpoints to vertical slices#925

Merged
ddaspit merged 1 commit into
mainfrom
engine-slices
Apr 23, 2026
Merged

Refactor all remaining engine endpoints to vertical slices#925
ddaspit merged 1 commit into
mainfrom
engine-slices

Conversation

@ddaspit
Copy link
Copy Markdown
Contributor

@ddaspit ddaspit commented Apr 20, 2026

@ddaspit ddaspit force-pushed the engine-slices branch 2 times, most recently from 44e09e4 to 8885c96 Compare April 20, 2026 20:42
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 86.35983% with 163 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.18%. Comparing base (8fb56ee) to head (0926e8b).

Files with missing lines Patch % Lines
...on/Features/Engines/GetAllCorpusPretranslations.cs 0.00% 44 Missing ⚠️
...atures/Engines/GetCorpusPretranslationsByTextId.cs 0.00% 43 Missing ⚠️
...ion/Features/Engines/GetCorpusPretranslatedUsfm.cs 69.01% 21 Missing and 1 partial ⚠️
...anslation/Features/Engines/UpdateParallelCorpus.cs 87.73% 10 Missing and 3 partials ⚠️
...anslation/Features/Engines/GetPretranslatedUsfm.cs 91.54% 3 Missing and 3 partials ⚠️
...ion/Features/Engines/GetPretranslationsByTextId.cs 86.04% 3 Missing and 3 partials ⚠️
...c/Serval.Translation/Features/Engines/AddCorpus.cs 93.65% 2 Missing and 2 partials ⚠️
....Translation/Features/Engines/AddParallelCorpus.cs 94.36% 2 Missing and 2 partials ⚠️
...anslation/Features/Engines/PretranslationStatus.cs 71.42% 2 Missing and 2 partials ⚠️
...erval.Translation/Features/Engines/UpdateCorpus.cs 95.18% 2 Missing and 2 partials ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   65.96%   66.18%   +0.22%     
==========================================
  Files         350      371      +21     
  Lines       21167    21510     +343     
  Branches     2716     2739      +23     
==========================================
+ Hits        13962    14236     +274     
- Misses       6206     6270      +64     
- Partials      999     1004       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ddaspit ddaspit force-pushed the engine-slices branch 3 times, most recently from a7ad43b to 9ad3a4e Compare April 21, 2026 20:06
@pmachapman pmachapman self-requested a review April 22, 2026 23:31
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman partially reviewed 48 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@ddaspit ddaspit merged commit 8c7ec4d into main Apr 23, 2026
2 checks passed
@ddaspit ddaspit deleted the engine-slices branch April 23, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move remaining translation engine endpoints to vertical slices

3 participants