Add endpoint to retrieve all pretranslation confidences#935
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
==========================================
+ Coverage 66.71% 66.73% +0.01%
==========================================
Files 371 372 +1
Lines 21562 21687 +125
Branches 2745 2771 +26
==========================================
+ Hits 14386 14472 +86
- Misses 6149 6179 +30
- Partials 1027 1036 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93 and pmachapman).
src/Serval/src/Serval.Translation/Features/Engines/GetAllPretranslationConfidences.cs line 5 at r1 (raw file):
public record PretranslationConfidenceDto { public required IReadOnlyList<string> TargetRefs { get; init; }
Do we need TextId and SourceRefs?
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ddaspit and Enkidu93).
src/Serval/src/Serval.Translation/Features/Engines/GetAllPretranslationConfidences.cs line 5 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Do we need
TextIdandSourceRefs?
No, as I want to keep this as small as possible, and in SF we only use the TargetRefs. I think if an application/use case needed TextId or SourceRefs, they could use the full GetAllPretranslations endpoint.
|
Previously, pmachapman (Peter Chapman) wrote…
Just curious, Peter: Do you use |
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ddaspit).
c8ad52b to
fc2c16d
Compare
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman made 1 comment.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on ddaspit and Enkidu93).
src/Serval/src/Serval.Translation/Features/Engines/GetAllPretranslationConfidences.cs line 5 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
Just curious, Peter: Do you use
template=Sourcewhen fetching USFM? I wonder if you should be using the source refs then. In most cases, it wouldn't matter, but I think it is possible that a verse could be mismapped or at least collide with another verse.
Done. I have added the source refs.
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
fc2c16d to
863b6b2
Compare
Fixes #933
This change is