Skip to content

Conversation

@megahirt
Copy link
Collaborator

@megahirt megahirt commented Dec 1, 2021

Description

This PR removes a reference to a file that used to be our main application JS bundle. Our webpack config changed and now this file doesn't exist anymore.

Type of Change

Only keep lines below that describe this change, then delete the rest.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

This PR resolves the console error:
image

How Has This Been Tested?

Please describe the manual tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • The 404 console error is no longer present

Checklist:

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

This commit removes a reference to a file that used to be our main application JS bundle.  Our webpack config changed and now this file doesn't exist anymore.
@megahirt megahirt changed the base branch from develop to staging December 1, 2021 07:42
Copy link
Contributor

@longrunningprocess longrunningprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phew, I can sleep again at night, thank you for dealing with this nuisance!

Would you mind reviewing #1258? Once that one goes into develop you'll start getting your unit test checks again. Thanks.

@longrunningprocess longrunningprocess added the engineering Tasks which do not directly relate to a user-facing feature or fix label Dec 1, 2021
@megahirt megahirt merged commit 617c0cc into staging Dec 2, 2021
@megahirt megahirt deleted the bugfix/404file branch December 2, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engineering Tasks which do not directly relate to a user-facing feature or fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants