Skip to content

SF-3333b Reduce calls to the DBL, PT, and RTS when configuring sources#3187

Merged
RaymondLuong3 merged 2 commits intomasterfrom
fix/SF-3333b
May 8, 2025
Merged

SF-3333b Reduce calls to the DBL, PT, and RTS when configuring sources#3187
RaymondLuong3 merged 2 commits intomasterfrom
fix/SF-3333b

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented May 5, 2025

This PR:

  • Improves real time server connection reuse when updating settings
  • Reduces the calls made to ParatextData (for Projects) or the DBL (for Resources) for scenarios when:
    • More than one user is on a project or resource
    • A resource or project is used for both the training and translation sources.

Testing Notes:


This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.01%. Comparing base (5a0e932) to head (bfa9007).
Report is 100 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3187   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files         569      569           
  Lines       33203    33217   +14     
  Branches     5355     5350    -5     
=======================================
+ Hits        27562    27575   +13     
  Misses       4838     4838           
- Partials      803      804    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmachapman pmachapman changed the title WIP: SF-3333b Reduce calls to the DBL, PT, and RTS when configuring sources SF-3333b Reduce calls to the DBL, PT, and RTS when configuring sources May 5, 2025
@pmachapman pmachapman marked this pull request as ready for review May 5, 2025 23:29
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved

Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@RaymondLuong3 RaymondLuong3 merged commit 15a2627 into master May 8, 2025
18 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/SF-3333b branch May 8, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants