Skip to content

Conversation

@Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Jul 17, 2025

I've replaced uses of translate() with i18n.translateStatic() as much as possible, for greater type safety. We should favor this whenever possible. (I was motivated to do this after catching a incorrect localization key in code review recently).

I left lots of places untouched because updating tests wasn't trivial.


This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

❌ Patch coverage is 76.34409% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.55%. Comparing base (6c1f073) to head (22965d7).
⚠️ Report is 77 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pp/src/xforge-common/exception-handling.service.ts 42.85% 3 Missing and 1 partial ⚠️
...slate/draft-generation/draft-generation.service.ts 70.00% 3 Missing ⚠️
...Forge.Scripture/ClientApp/src/app/app.component.ts 33.33% 2 Missing ⚠️
...ientApp/src/app/core/translation-engine.service.ts 0.00% 2 Missing ⚠️
...ntApp/src/app/my-projects/my-projects.component.ts 66.66% 1 Missing and 1 partial ⚠️
...sers-dialog/supported-browsers-dialog.component.ts 0.00% 2 Missing ⚠️
...s/checking-comments/checking-comments.component.ts 75.00% 1 Missing ⚠️
...s/checking-question/checking-question.component.ts 0.00% 0 Missing and 1 partial ⚠️
...recorder-dialog/audio-recorder-dialog.component.ts 75.00% 1 Missing ⚠️
...Scripture/ClientApp/src/app/sync/sync.component.ts 66.66% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3319   +/-   ##
=======================================
  Coverage   82.55%   82.55%           
=======================================
  Files         605      605           
  Lines       35301    35311   +10     
  Branches     5720     5744   +24     
=======================================
+ Hits        29141    29151   +10     
+ Misses       5313     5301   -12     
- Partials      847      859   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami force-pushed the feature/use-i18n-translate branch from cecb6f2 to f8f4b67 Compare July 17, 2025 14:22
@pmachapman pmachapman force-pushed the feature/use-i18n-translate branch from f8f4b67 to 22965d7 Compare July 20, 2025 21:13
@pmachapman pmachapman self-requested a review July 20, 2025 21:13
@pmachapman pmachapman self-assigned this Jul 20, 2025
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 28 of 28 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)

@pmachapman pmachapman merged commit 34b95f8 into master Jul 20, 2025
18 checks passed
@pmachapman pmachapman deleted the feature/use-i18n-translate branch July 20, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants