Skip to content

SF-3487 Show language codes on mobile when configuring sources#3345

Merged
Nateowami merged 1 commit intomasterfrom
feature/SF-3487
Aug 7, 2025
Merged

SF-3487 Show language codes on mobile when configuring sources#3345
Nateowami merged 1 commit intomasterfrom
feature/SF-3487

Conversation

@Nateowami
Copy link
Copy Markdown
Collaborator

@Nateowami Nateowami commented Aug 5, 2025

Instead of hiding the overview area, it's now moved below the accordion area. This allows users to actually confirm the language codes are correct, even though it's not a great UI on mobile.


This change is Reviewable

@Nateowami Nateowami added the will require testing PR should not be merged until testers confirm testing is complete label Aug 5, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.42%. Comparing base (6d601c1) to head (4a3d37d).
⚠️ Report is 113 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3345   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files         607      607           
  Lines       35543    35543           
  Branches     5784     5784           
=======================================
+ Hits        29295    29297    +2     
+ Misses       5370     5369    -1     
+ Partials      878      877    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman self-assigned this Aug 5, 2025
@pmachapman pmachapman self-requested a review August 5, 2025 19:06
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Aug 5, 2025
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)

@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Aug 7, 2025
@Nateowami Nateowami merged commit 4bc37e4 into master Aug 7, 2025
18 checks passed
@Nateowami Nateowami deleted the feature/SF-3487 branch August 7, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants