Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3374 +/- ##
==========================================
+ Coverage 82.16% 82.21% +0.04%
==========================================
Files 609 609
Lines 35895 35901 +6
Branches 5863 5840 -23
==========================================
+ Hits 29493 29515 +22
- Misses 5519 5524 +5
+ Partials 883 862 -21 ☔ View full report in Codecov by Sentry. |
0f68a0d to
3c0703d
Compare
pmachapman
left a comment
There was a problem hiding this comment.
Just one very minor nit in a
.spec.ts file, so I will approve so to not hold up testing.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @siltomato)
src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/lynx/insights/lynx-insight-editor-objects/lynx-insight-editor-objects.component.spec.ts line 5 at r1 (raw file):
import { Delta } from 'quill'; import { BehaviorSubject } from 'rxjs'; import { TextDocId } from 'src/app/core/models/text-doc';
NIT: This should be:
import { TextDocId } from '../../../../../core/models/text-doc';(I also noticed this in \src\SIL.XForge.Scripture\ClientApp\src\app\translate\editor\lynx\insights\lynx-insight-overlay\lynx-insight-overlay.component.spec.ts)
Code quote:
import { TextDocId } from 'src/app/core/models/text-doc';3c0703d to
e427355
Compare
pmachapman
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @siltomato)
e427355 to
232ba24
Compare
This PR fixes an issue where the lynx overlay would not display when using the lynx problems panel to navigate to (and display the overlay for) an insight from a different chapter.
The fix involved waiting for the insights for the chapter to render before making the call to render the overlay.
This change is