Skip to content

SF-3587 Fix lingering lynx action prompt when changing book/chapter#3472

Merged
Nateowami merged 1 commit intomasterfrom
fix/sf-3587-lynx-insight-icon-visible-after-book-switch
Oct 1, 2025
Merged

SF-3587 Fix lingering lynx action prompt when changing book/chapter#3472
Nateowami merged 1 commit intomasterfrom
fix/sf-3587-lynx-insight-icon-visible-after-book-switch

Conversation

@siltomato
Copy link
Collaborator

@siltomato siltomato commented Sep 26, 2025

This PR fixes an issue where the lynx action prompt was not clearing when changing book/chapter. The fix is to clear the insight display state on book/chapter change. This clearing will happen before active insights are assigned from the problems panel on insight nav.


This change is Reviewable

@siltomato siltomato added the will require testing PR should not be merged until testers confirm testing is complete label Sep 26, 2025
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.19%. Comparing base (d0ff8ed) to head (3cf52c8).
⚠️ Report is 78 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3472   +/-   ##
=======================================
  Coverage   82.18%   82.19%           
=======================================
  Files         611      611           
  Lines       36449    36452    +3     
  Branches     5981     6005   +24     
=======================================
+ Hits        29957    29960    +3     
+ Misses       5623     5610   -13     
- Partials      869      882   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siltomato siltomato marked this pull request as ready for review September 26, 2025 21:14
@pmachapman pmachapman self-requested a review September 28, 2025 19:23
@pmachapman pmachapman self-assigned this Sep 28, 2025
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @siltomato)

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Sep 28, 2025
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Oct 1, 2025
@Nateowami Nateowami force-pushed the fix/sf-3587-lynx-insight-icon-visible-after-book-switch branch from f731914 to 3cf52c8 Compare October 1, 2025 13:00
@Nateowami Nateowami enabled auto-merge (squash) October 1, 2025 13:00
@Nateowami Nateowami merged commit a96e7d0 into master Oct 1, 2025
21 checks passed
@Nateowami Nateowami deleted the fix/sf-3587-lynx-insight-icon-visible-after-book-switch branch October 1, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants