Skip to content

Conversation

@siltomato
Copy link
Collaborator

@siltomato siltomato commented Oct 30, 2025

This PR sets the lynx problems panel sample text font to match the project font.

The project text font is set in css var --project-font on the component host element style attribute and then referenced for the css font-family of the sample text element.


This change is Reviewable

@siltomato siltomato added the will require testing PR should not be merged until testers confirm testing is complete label Oct 30, 2025
@siltomato siltomato force-pushed the sf-3627-lynx-insight-panel-sample-text-font branch from 93f86b0 to 0003d99 Compare October 30, 2025 22:21
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.92%. Comparing base (13bacab) to head (69ecc5b).
⚠️ Report is 52 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3551   +/-   ##
=======================================
  Coverage   82.92%   82.92%           
=======================================
  Files         605      605           
  Lines       36898    36900    +2     
  Branches     6050     6050           
=======================================
+ Hits        30596    30598    +2     
  Misses       5389     5389           
  Partials      913      913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siltomato siltomato force-pushed the sf-3627-lynx-insight-panel-sample-text-font branch from 0003d99 to 188dce7 Compare November 3, 2025 20:43
@pmachapman pmachapman self-requested a review November 4, 2025 00:02
@pmachapman pmachapman self-assigned this Nov 4, 2025
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @siltomato)

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Nov 4, 2025
@RaymondLuong3 RaymondLuong3 force-pushed the sf-3627-lynx-insight-panel-sample-text-font branch from 188dce7 to 69ecc5b Compare November 5, 2025 16:43
@pmachapman pmachapman added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Nov 5, 2025
@pmachapman pmachapman merged commit c5708ff into master Nov 5, 2025
29 of 30 checks passed
@pmachapman pmachapman deleted the sf-3627-lynx-insight-panel-sample-text-font branch November 5, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants