Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Nov 4, 2025

This PR ensures that when drafts are retrieved from Serval that embed markers and style markers are stripped, ensuring that for translations with footnotes, these footnotes are not carried across into the draft in Scripture Forge.

This will not affect current drafts already in Scripture Forge until either:

  1. The webhook is re-run.
  2. Or, the Formatting options are changed.

This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.90%. Comparing base (7390b24) to head (3f439c8).
⚠️ Report is 50 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3559   +/-   ##
=======================================
  Coverage   82.90%   82.90%           
=======================================
  Files         605      605           
  Lines       36974    36976    +2     
  Branches     6035     6054   +19     
=======================================
+ Hits        30654    30656    +2     
+ Misses       5405     5392   -13     
- Partials      915      928   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@RaymondLuong3 reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@RaymondLuong3 RaymondLuong3 changed the title SF-2632 Specify style marker and embed marker behavior as strip SF-3632 Specify style marker and embed marker behavior as strip Nov 6, 2025
@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Nov 6, 2025
@RaymondLuong3 RaymondLuong3 self-assigned this Nov 6, 2025
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Nov 7, 2025
@RaymondLuong3 RaymondLuong3 merged commit d720910 into master Nov 7, 2025
23 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/SF-3632 branch November 7, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants