Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Jan 28, 2026

This PR helps the SignalR server and client to reconnect and resend any missed messages if the connection is interrupted for some reason, such as connectivity issues.

I have also cherrypicked a commit from #3638 that will unsubscribed from notifications, to ensure that the server does not remember messages for clients that no longer require SignalR notifications for a sync or draft.


This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.90%. Comparing base (f5e9bcc) to head (4a3f116).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/SIL.XForge.Scripture/Startup.cs 0.00% 4 Missing ⚠️
...ntApp/src/app/core/project-notification.service.ts 0.00% 3 Missing ⚠️
.../app/sync/sync-progress/sync-progress.component.ts 75.00% 1 Missing ⚠️
...draft-history-list/draft-history-list.component.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3655      +/-   ##
==========================================
- Coverage   81.91%   81.90%   -0.01%     
==========================================
  Files         618      618              
  Lines       38542    38551       +9     
  Branches     6285     6309      +24     
==========================================
+ Hits        31570    31574       +4     
+ Misses       6012     6004       -8     
- Partials      960      973      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman).

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this to QA and see if it makes a difference. I have seen drafts on QA that complete but a page refresh is needed to see the new draft.

@RaymondLuong3 made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman).

@RaymondLuong3 RaymondLuong3 self-assigned this Feb 10, 2026
@RaymondLuong3 RaymondLuong3 merged commit e285369 into master Feb 10, 2026
23 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/SF-3686 branch February 10, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants