Skip to content

Comments

Add endpoint to get project metadata by SF id or Paratext id#3697

Merged
RaymondLuong3 merged 1 commit intomasterfrom
feature/get-project-metadata-by-any-id
Feb 20, 2026
Merged

Add endpoint to get project metadata by SF id or Paratext id#3697
RaymondLuong3 merged 1 commit intomasterfrom
feature/get-project-metadata-by-any-id

Conversation

@Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Feb 18, 2026

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.74%. Comparing base (2d11aef) to head (addab40).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ture/Controllers/OnboardingRequestRpcController.cs 0.00% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3697      +/-   ##
==========================================
- Coverage   81.83%   81.74%   -0.09%     
==========================================
  Files         619      619              
  Lines       38623    38663      +40     
  Branches     6293     6316      +23     
==========================================
  Hits        31606    31606              
- Misses       6056     6083      +27     
- Partials      961      974      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami force-pushed the feature/get-project-metadata-by-any-id branch 2 times, most recently from c991b54 to 4bec053 Compare February 18, 2026 18:46
@RaymondLuong3 RaymondLuong3 force-pushed the feature/get-project-metadata-by-any-id branch from 4bec053 to 0a1a0f0 Compare February 19, 2026 20:18
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to create tests for the controller? I see there is currently no tests for this class, and I recall that was mostly intentional

@RaymondLuong3 reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Nateowami).


src/SIL.XForge.Scripture/Controllers/OnboardingRequestRpcController.cs line 555 at r2 (raw file):

            bool hasParatextId = !string.IsNullOrEmpty(paratextId);
            bool hasScriptureForgeId = !string.IsNullOrEmpty(scriptureForgeId);
            if (hasParatextId == hasScriptureForgeId)

You could also use the xor operator to achieve the same thing.

Code quote (i):

            if (hasParatextId == hasScriptureForgeId)

Code snippet (ii):

if (hasParatextId ^ hasScriptureForgeId)

@RaymondLuong3 RaymondLuong3 self-assigned this Feb 19, 2026
Copy link
Collaborator Author

@Nateowami Nateowami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should probably have tests added as some point, but so far the requirements have changed rapidly enough that it hasn't seemed worth it. I think I will add them in a future PR.

@Nateowami made 2 comments and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).


src/SIL.XForge.Scripture/Controllers/OnboardingRequestRpcController.cs line 555 at r2 (raw file):

Previously, RaymondLuong3 (Raymond Luong) wrote…

You could also use the xor operator to achieve the same thing.

I think XOR would have != semantics. Also, I think == better expresses intent.

@RaymondLuong3 RaymondLuong3 force-pushed the feature/get-project-metadata-by-any-id branch from 0a1a0f0 to addab40 Compare February 19, 2026 23:59
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 made 1 comment and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).


src/SIL.XForge.Scripture/Controllers/OnboardingRequestRpcController.cs line 555 at r2 (raw file):

Previously, Nateowami wrote…

I think XOR would have != semantics. Also, I think == better expresses intent.

That works for me. Not a big deal.

@RaymondLuong3 RaymondLuong3 enabled auto-merge (squash) February 20, 2026 00:00
@RaymondLuong3 RaymondLuong3 merged commit 595481b into master Feb 20, 2026
21 checks passed
@RaymondLuong3 RaymondLuong3 deleted the feature/get-project-metadata-by-any-id branch February 20, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants