Add endpoint to get project metadata by SF id or Paratext id#3697
Add endpoint to get project metadata by SF id or Paratext id#3697RaymondLuong3 merged 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3697 +/- ##
==========================================
- Coverage 81.83% 81.74% -0.09%
==========================================
Files 619 619
Lines 38623 38663 +40
Branches 6293 6316 +23
==========================================
Hits 31606 31606
- Misses 6056 6083 +27
- Partials 961 974 +13 ☔ View full report in Codecov by Sentry. |
c991b54 to
4bec053
Compare
4bec053 to
0a1a0f0
Compare
RaymondLuong3
left a comment
There was a problem hiding this comment.
Did you want to create tests for the controller? I see there is currently no tests for this class, and I recall that was mostly intentional
@RaymondLuong3 reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Nateowami).
src/SIL.XForge.Scripture/Controllers/OnboardingRequestRpcController.cs line 555 at r2 (raw file):
bool hasParatextId = !string.IsNullOrEmpty(paratextId); bool hasScriptureForgeId = !string.IsNullOrEmpty(scriptureForgeId); if (hasParatextId == hasScriptureForgeId)
You could also use the xor operator to achieve the same thing.
Code quote (i):
if (hasParatextId == hasScriptureForgeId)Code snippet (ii):
if (hasParatextId ^ hasScriptureForgeId)
Nateowami
left a comment
There was a problem hiding this comment.
It should probably have tests added as some point, but so far the requirements have changed rapidly enough that it hasn't seemed worth it. I think I will add them in a future PR.
@Nateowami made 2 comments and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).
src/SIL.XForge.Scripture/Controllers/OnboardingRequestRpcController.cs line 555 at r2 (raw file):
Previously, RaymondLuong3 (Raymond Luong) wrote…
You could also use the xor operator to achieve the same thing.
I think XOR would have != semantics. Also, I think == better expresses intent.
0a1a0f0 to
addab40
Compare
RaymondLuong3
left a comment
There was a problem hiding this comment.
@RaymondLuong3 made 1 comment and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Nateowami).
src/SIL.XForge.Scripture/Controllers/OnboardingRequestRpcController.cs line 555 at r2 (raw file):
Previously, Nateowami wrote…
I think XOR would have
!=semantics. Also, I think==better expresses intent.
That works for me. Not a big deal.
This change is