Merged
Conversation
Q-Dub
requested changes
Feb 2, 2026
Contributor
Q-Dub
left a comment
Q-Dub
left a comment
There was a problem hiding this comment.
Looks fantastic overall, just two points of feedback via request changes.
docs/secret-management-user-guide.md
Outdated
| **Cluster-Wide:** | ||
| - `secrets/cluster-domain` - Domain for ingress and routing | ||
|
|
||
| **AIRM Application:** |
Contributor
There was a problem hiding this comment.
better to ref the source of truth over duplication which is just another thing that can fall out of sync
| - Used for: Testing and default values | ||
|
|
||
| ### 5. Secret Flow Architecture | ||
| ### 6. Secret Flow Architecture |
Contributor
There was a problem hiding this comment.
this is nice, but suggestion: have intern convert to mermaid to increase maintainability
Q-Dub
approved these changes
Feb 3, 2026
tomastola
pushed a commit
that referenced
this pull request
Mar 4, 2026
* docs: add docs about new openbao config * docs: refactor secret management docs * docs: refactor secret management docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds/updates docs describing new openbao init config.