Skip to content

Feature/BA 3006 multiple profiles invitation expiration and retry logic#391

Merged
gabrielalmeida-tsl merged 1 commit intoepic/multiples-profilesfrom
feature/BA-3006-multiple-profiles-invitation-expiration-and-retry-logic
Feb 24, 2026
Merged

Feature/BA 3006 multiple profiles invitation expiration and retry logic#391
gabrielalmeida-tsl merged 1 commit intoepic/multiples-profilesfrom
feature/BA-3006-multiple-profiles-invitation-expiration-and-retry-logic

Conversation

@gabrielalmeida-tsl
Copy link

@gabrielalmeida-tsl gabrielalmeida-tsl commented Feb 23, 2026

Summary

  • Handle email delivery failures gracefully in SendInvitation and ResendInvitation mutations using try/except with logging, so the invitation is still created/updated even if the email service fails
  • Add emailSent boolean field to both mutation responses, allowing the frontend to show appropriate feedback when email delivery fails
  • Add tests covering email failure scenarios for both send and resend flows

Context

This addresses the concern raised in PR #368 comment about what happens when the email service fails to send an invitation. Previously, if send_invitation_email() raised an exception, the entire mutation would fail and the database transaction would roll back — leaving no record of the invitation attempt. Now the mutation succeeds regardless of email delivery, and the emailSent response field lets the frontend inform the user and offer a resend option.

@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/BA-3006-multiple-profiles-invitation-expiration-and-retry-logic

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gabrielalmeida-tsl gabrielalmeida-tsl force-pushed the feature/BA-3006-multiple-profiles-invitation-expiration-and-retry-logic branch from e1b5f98 to 8a6cfe4 Compare February 23, 2026 14:56
@gabrielalmeida-tsl gabrielalmeida-tsl merged commit cfb8740 into epic/multiples-profiles Feb 24, 2026
5 checks passed
@gabrielalmeida-tsl gabrielalmeida-tsl deleted the feature/BA-3006-multiple-profiles-invitation-expiration-and-retry-logic branch February 24, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants