Skip to content

BA-2334: fix flaky test #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

BA-2334: fix flaky test #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/components/modules/comments/web/Comments/__tests__/Comments.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,14 +215,15 @@ describe('Comments', () => {
cy.step('Scroll to the bottom and see the next 5 comments')

cy.findByText('Fourth comment').should('exist').scrollIntoView()
cy.findByText('Fifth comment').should('exist').scrollIntoView()

cy.findByLabelText('loading more comments')
.should('exist')
.scrollIntoView()
.then(() => {
resolveMostRecentOperation({ data: commentsNextPageMockData })
})
cy.findByText('Fifth comment').should('exist')

cy.findByLabelText('loading more comments').should('not.exist')
cy.findByText('Sixth comment').should('exist').scrollIntoView()
cy.findByText('Seventh comment').should('exist')
cy.findByText('Eighth comment').should('exist').scrollIntoView()
Expand All @@ -231,7 +232,6 @@ describe('Comments', () => {

cy.step('Scroll to the bottom should not trigger another fetch')
cy.findByText('Tenth comment').scrollIntoView()
cy.findByLabelText('loading more comments').should('not.exist')
})

it('should be able to render all comment`s replies', () => {
Expand Down
Loading