BA-2560: fix tests #268
BA-2560: fix tests #268
Conversation
priscilladeroode
requested review from
anicioalexandre and
deboracosilveira
as code owners
|
WalkthroughThis update refactors test utilities and test suites for navigation and authentication components. It introduces new test wrapper components for easier context provisioning, standardizes initial profile/context passing, adds test IDs, and updates provider composition in the design system tests. Additionally, it downgrades the Changes
Sequence Diagram(s)sequenceDiagram
participant TestSuite
participant ForTestingComponent
participant withComponentCompleteTestProviders
participant ContextProviders
participant TargetComponent
TestSuite->>ForTestingComponent: Mount with props (theme, context, etc.)
ForTestingComponent->>withComponentCompleteTestProviders: Wrap TargetComponent
withComponentCompleteTestProviders->>ContextProviders: Provide contexts (theme, UISettings, etc.)
ContextProviders->>TargetComponent: Render with provided contexts
TargetComponent-->>TestSuite: Expose test IDs, state, etc.
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/components/modules/comments/web/Comments/__tests__/__mocks__/requests.tsOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /packages/components/.eslintrc.js
packages/authentication/modules/tests/utils/providers/withAuthenticationTestProviders/index.tsxOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /packages/authentication/.eslintrc.js
packages/components/modules/comments/web/Comments/__tests__/Comments.cy.tsxOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /packages/components/.eslintrc.js
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (28)
💤 Files with no reviewable changes (3)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (21)
🧰 Additional context used🪛 LanguageToolpackages/wagtail/CHANGELOG.md[grammar] ~5-~5: Use correct spacing (QB_NEW_EN_OTHER_ERROR_IDS_5) [grammar] ~7-~7: Use colons correctly (QB_NEW_EN_OTHER_ERROR_IDS_30) [grammar] ~8-~8: There might be a problem here. (QB_NEW_EN_MERGED_MATCH) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
priscilladeroode
force-pushed
the
feature/BA-2560-fe-packages-component-test-fix
branch
from
d10e460 to
2cd7f52
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
packages/authentication/CHANGELOG.md (2)
3-4: Consider adding a release date to keep the changelog machine- and human-friendly
Previous entries don’t always include dates, but adding one here improves traceability and aligns with Keep a Changelog recommendations.-## 5.0.1 +## 5.0.1 — 2025-07-XX
7-7: Minor wording tweak for clarity
“dependencies update” reads a bit awkwardly; pluralising “dependency” keeps the phrasing consistent with other entries.-- Fix component tests after dependencies update. +- Fix component tests after dependency updates.packages/wagtail/CHANGELOG.md (1)
1-4: Minor markdown spacing / style nitFor readability, insert a blank line between the package header (
# @baseapp-frontend/wagtail) and the version heading to match the spacing used in older entries.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
packages/authentication/CHANGELOG.md(1 hunks)packages/authentication/package.json(1 hunks)packages/components/CHANGELOG.md(1 hunks)packages/components/package.json(1 hunks)packages/design-system/CHANGELOG.md(1 hunks)packages/design-system/package.json(1 hunks)packages/wagtail/CHANGELOG.md(1 hunks)packages/wagtail/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- packages/wagtail/package.json
- packages/components/package.json
- packages/authentication/package.json
- packages/design-system/package.json
- packages/components/CHANGELOG.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
packages/design-system/CHANGELOG.md
9-9: Multiple headings with the same content
(MD024, no-duplicate-heading)
🪛 LanguageTool
packages/wagtail/CHANGELOG.md
[grammar] ~3-~3: Use proper spacing conventions.
Context: # @baseapp-frontend/wagtail ## 1.0.32 ### Patch Changes - Updated dependencies ...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
[grammar] ~5-~5: Use proper spacing conventions.
Context: ...nd/wagtail ## 1.0.32 ### Patch Changes - Updated dependencies - @baseapp-fronte...
(QB_NEW_EN_OTHER_ERROR_IDS_000007)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build and Lint Packages
- GitHub Check: Component Test Packages
priscilladeroode
force-pushed
the
feature/BA-2560-fe-packages-component-test-fix
branch
from
078ff65 to
7e4d99e
Compare
|
priscilladeroode
deleted the
feature/BA-2560-fe-packages-component-test-fix
branch
Fix component tests
Summary by CodeRabbit
New Features
Refactor
Chores
simplebar-reactfor compatibility.