Use "tracing" for logs and set SYNCHRONOUS to NORMAL for writes#6
Merged
jjhafer merged 3 commits intosilvermine:masterfrom Nov 24, 2025
Merged
Conversation
Contributor
pmorris-dev
commented
Nov 21, 2025
pmorris-dev
commented
- We protect against log statements being compiled into release binaries
- See here for information on the SYNCHRONOUS setting
- We protect against ever compiling log statements into release binaries
velocitysystems
approved these changes
Nov 24, 2025
pmorris-dev
force-pushed
the
use_tracing_for_logs
branch
from
1aec584 to
5da0d5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.