feat: add API backing functions#8
Merged
jjhafer merged 1 commit intosilvermine:masterfrom Dec 1, 2025
Merged
Conversation
pmorris-dev
force-pushed
the
api_backing
branch
5 times, most recently
from
38bb073 to
86dd704
Compare
velocitysystems
suggested changes
Dec 1, 2025
pmorris-dev
force-pushed
the
api_backing
branch
from
86dd704 to
94da28f
Compare
velocitysystems
suggested changes
Dec 1, 2025
velocitysystems
suggested changes
Dec 1, 2025
pmorris-dev
force-pushed
the
api_backing
branch
from
94da28f to
ccffb13
Compare
- Consolidated transaction API to address a design flaw
- Calling BEGIN and then ceding the write conn could
leave an open transaction dangling
- Added backing functions to wrapper.rs
- Added decoder and tests
- Added tests for error types
- Remove the idea that an error will throw when
attempting a RO query with the writer. It's obvious
from the return type you'll get no query results
- NOTE: Integration tests and migrations coming soon
pmorris-dev
force-pushed
the
api_backing
branch
from
ccffb13 to
173e7cf
Compare
velocitysystems
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leave an open transaction dangling
attempting a RO query with the writer. It's obvious
from the return type you'll get no query results