Repository navigation
Replies: 2 comments
|
Yes, this is a clean addition. Wired the same way as cuda/metal/coreml, and we're already on whisper-rs 0.16, so it really is just the few feature lines you sketched out. I'd love a PR. Two small things I'd ask for:
No need to touch CI or the Homebrew formula. Source-install only is the right scope. If you hit anything weird while testing on your own hardware, please drop notes on the PR. AMD GPU support is something I've wanted for the Linux story but don't have the hardware to validate myself. Thanks for offering to do the work! |
|
Thanks again for raising this and for following through with the PR. This is now merged in #99, so Minutes supports the Really appreciate the contribution and the hardware validation notes on AMD/Vulkan too. |
Uh oh!
There was an error while loading. Please reload this page.
whisper-rs 0.16 exposes
vulkanandhipblasfeature flags (from whisper.cpp), but minutes doesn't wire them through yet. Adding these would let AMD GPU users (and anyone with Vulkan support) get hardware-accelerated transcription.The change would be small, following the same pattern as the existing
cuda/metal/coremlflags:Then users could install with:
cargo install minutes-cli --features vulkan # or cargo install minutes-cli --features hipblasI haven't tested either backend myself, so I'm not sure if there are runtime quirks beyond wiring the features through. Happy to put up a PR if this seems reasonable.
All reactions