DOC Add section on ORM performance#201
Merged
emteknetnz merged 1 commit intosilverstripe:5from Apr 3, 2023
Merged
Conversation
5 tasks
dfb49dc to
9cb5954
Compare
This is just a couple of things for now - there are definitely more items that should be added here.
9cb5954 to
c048ec9
Compare
emteknetnz
approved these changes
Apr 3, 2023
Member
|
@GuySartorelli I probably merged this too soon, for 06_ORM.md could you open a new PR to mention that it'll disable the check and repair for the tables on the entire inheritance chain, both ancestors and descendants I'm fairly sure that's accurate? I tested it with both and using a breakpoint on a temporary variable For both configurations it skip the check and repair for the models SiteTree, Page, ErrorPage, etc - implying that the "inheritance chain" goes in both directions Let me know if I've misunderstood this |
Member
Author
|
Yup that's correct - the unit test even explicitly ensures that's the case. I'll raise a new PR to add that context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a couple of things for now - there are definitely more items that should be added here.
This section was mostly added because I needed a place to put the documentation for silverstripe/silverstripe-framework#10746 - but I bet there are a ton of additional bits and bobs we can document here as well (such as silverstripe/silverstripe-framework#10735 when it's merged)
I've created a separate card to look for other items that should be documented here.
Issue