Skip to content

Conversation

@emteknetnz
Copy link
Member

Issue #770

@emteknetnz emteknetnz mentioned this pull request Jul 10, 2025
3 tasks
@emteknetnz emteknetnz marked this pull request as ready for review July 10, 2025 04:10
Comment on lines 89 to 94

#### Other performance improvements
### Other performance improvements

- Previously there were a large number of unnecessary AJAX requests made to fetch the form schema for the search form for sections of the CMS that are searchable such as the site tree i.e. the list of pages on `/admin/page`. This has been fixed so these requests are only made when the filter button is clicked. Note this enhacement was originally released as a patch for CMS 5.4.
- There have been a number of other smaller performance enhancements that have been included in this release. Some of these enhacements were also released as patch releases for CMS 5.4.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit weird in the middle of the features and enhancements - maybe just merge this into "other new features"

@emteknetnz emteknetnz force-pushed the pulls/6/remove-perf branch from c162cd3 to 985db04 Compare July 10, 2025 22:01
@emteknetnz emteknetnz force-pushed the pulls/6/remove-perf branch from 985db04 to 358d2fb Compare July 10, 2025 22:04
@emteknetnz
Copy link
Member Author

Updated

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit d8f3990 into silverstripe:6 Jul 10, 2025
3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/remove-perf branch July 10, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants