Skip to content

Conversation

@emteknetnz
Copy link
Member

@emteknetnz emteknetnz marked this pull request as ready for review September 29, 2025 01:49
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli
Copy link
Member

Will merge when CI goes green

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the whitespace back.

The details HTML tag is really finnicky, and sometimes screws up when there's no space above the closing tab or below the summary tag. I notice this all the time in GitHub itself. It's unclear how our docs renderer would handle it but I'd rather not find out.

@GuySartorelli GuySartorelli merged commit 672841e into silverstripe:6.1 Sep 29, 2025
3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6.1/changelog branch September 29, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants