[pull] master from moby:master#772
Merged
pull[bot] merged 2 commits intosim0nj:masterfrom Oct 21, 2020
Merged
Conversation
This fixes a regression based on expectations of the runtime: ``` docker pull arm32v7/alpine docker run arm32v7/alpine ``` Without this change, the `docker run` will fail due to platform matching on non-arm32v7 systems, even though the image could run (assuming the system is setup correctly). This also emits a warning to make sure that the user is aware that a platform that does not match the default platform of the system is being run, for the cases like: ``` docker pull --platform armhf busybox docker run busybox ``` Not typically an issue if the requests are done together like that, but if the image was already there and someone did `docker run` without an explicit `--platform`, they may very well be expecting to run a native version of the image instead of the armhf one. This warning does add some extra noise in the case of platform specific images being run, such as `arm32v7/alpine`, but this can be supressed by explicitly setting the platform. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Don't set default platform on container create
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )