Skip to content

Update doctrine/coding-standard requirement from ^8.2 to ^9.0 #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simPod merged 2 commits into from
Jun 26, 2021
Merged

Update doctrine/coding-standard requirement from ^8.2 to ^9.0 #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6167adb
Update doctrine/coding-standard requirement from ^8.2 to ^8.2 || ^9.0
dependabot[bot] Jun 26, 2021
20db495
Fix CS
simPod Jun 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"webonyx/graphql-php": "^14.0"
},
"require-dev": {
"doctrine/coding-standard": "^8.2",
"doctrine/coding-standard": "^9.0",
"infection/infection": "^0.23.0",
"phpstan/extension-installer": "^1.1",
"phpstan/phpstan": "0.12.90",
Expand Down
4 changes: 1 addition & 3 deletions src/Exception/InvalidArgument.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ public static function invalidNameFormat(string $invalidName): self
return new self(sprintf('Name "%s" does not match pattern "%s"', $invalidName, TypeBuilder::VALID_NAME_PATTERN));
}

/**
* @param mixed $invalidValue
*/
/** @param mixed $invalidValue */
public static function valueNotIso8601Compliant($invalidValue): self
{
return new self(sprintf('DateTime type expects input value to be ISO 8601 compliant. Given invalid value "%s"', (string) $invalidValue));
Expand Down
14 changes: 3 additions & 11 deletions src/Type/DateTimeType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ public function __construct()
);
}

/**
* @param mixed $value
*/
/** @param mixed $value */
public function serialize($value): string
{
if (! $value instanceof DateTimeInterface) {
Expand All @@ -62,9 +60,7 @@ public function serialize($value): string
return $value->format(DateTimeInterface::ATOM);
}

/**
* @param mixed $value
*/
/** @param mixed $value */
public function parseValue($value): DateTimeImmutable
{
if (! is_string($value)) {
Expand All @@ -78,11 +74,7 @@ public function parseValue($value): DateTimeImmutable
return new DateTimeImmutable($value);
}

/**
* @param mixed[]|null $variables
*
* @phpcsSuppress SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingNativeTypeHint
*/
/** @param mixed[]|null $variables */
public function parseLiteral(Node $valueNode, ?array $variables = null): ?DateTimeImmutable
{
if (! $valueNode instanceof StringValueNode) {
Expand Down