Skip to content

Add httpStatusCode and clickHouseExceptionName to ServerError#322

Merged
simPod merged 1 commit intomasterfrom
claude/richer-server-error-context
Mar 27, 2026
Merged

Add httpStatusCode and clickHouseExceptionName to ServerError#322
simPod merged 1 commit intomasterfrom
claude/richer-server-error-context

Conversation

@simPod
Copy link
Copy Markdown
Owner

@simPod simPod commented Mar 27, 2026

Summary

  • Adds public readonly int $httpStatusCode and public readonly string|null $clickHouseExceptionName to ServerError
  • Parses the ClickHouse exception name (e.g. NOT_IMPLEMENTED) from the error body
  • Makes debugging easier without needing to enable SQL logging

Test plan

  • Existing testParseCode extended to assert new properties
  • New testParseWithoutExceptionName covers fallback when body has no recognizable exception name
  • PHPStan and PHPCS pass

https://claude.ai/code/session_01YX19TXMGf89gacogUmxHJM

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.57%. Comparing base (ddb1e57) to head (7cc97a0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   94.49%   94.57%   +0.07%     
==========================================
  Files          42       42              
  Lines         709      719      +10     
==========================================
+ Hits          670      680      +10     
  Misses         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simPod simPod merged commit 69e1cc8 into master Mar 27, 2026
19 checks passed
@simPod simPod deleted the claude/richer-server-error-context branch March 27, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants