feat: Add HasChanged to all scalar input types#24
Merged
sjuergen merged 1 commit intosimatic-ax:mainfrom Dec 18, 2024
Merged
Conversation
simonkampe
requested review from
BeckerStS,
kruegerfelix and
sjuergen
as code owners
|
|
simonkampe
force-pushed
the
add_has_changed
branch
from
e08d179 to
6421f24
Compare
sjuergen
reviewed
Nov 11, 2024
simonkampe
force-pushed
the
add_has_changed
branch
from
6421f24 to
08f854c
Compare
Member
|
@simonkampe I added some comments |
sjuergen
approved these changes
Dec 2, 2024
Member
|
@simonkampe pull request accepted |
Member
|
@simonkampe could you please solve the conflict in your pull request? |
Add HasChanged functionality to all inputs Add tolerance to all analog inputs (except WORD) Corrections to documentation comments Add System.Math library Add unit tests for new functionality
simonkampe
force-pushed
the
add_has_changed
branch
from
08f854c to
ffbf809
Compare
Contributor
Author
Done. |
sjuergen
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HasChanged() to all scalars
Add CyclicRead with REAL datatype to RealInput
Correct comment in LRealInput
Adds @ax/system-math for ABS() to compare value
difference to tolerance (only for floating
point types)
This is my first time making a PR to this project, so please feedback commit formatting, code style etc :)