Refac NASA service and test impl (graphite-agent)

README.md

@@ -24,7 +24,17 @@ A template for creating AWS Lambda functions with Python, using Docker images st
 ├── .github/workflows         # Example GitHub Actions workflows
 ├── cloudformation            # Example CloudFormation templates
 ├── models                    # Pydantic models for data validation
+│   ├── event.py              # API Gateway event model
+│   ├── exceptions.py         # Custom exceptions
+│   └── response.py           # Standardized response models
 ├── services                  # Business logic and external service integrations
+│   ├── aws.py                # AWS service wrappers (Secrets Manager)
+│   ├── db.py                 # MySQL database driver
+│   ├── migrations.py         # Migration repository
+│   ├── nasa.py               # NASA API service
+│   └── rest_api.py           # Base REST API service
+├── tests                     # Unit tests
+│   └── test_lambda_function.py
 ├── utils                     # Utility functions (e.g., logger, config)
 ├── .pre-commit-config.yaml   # Configuration for pre-commit hooks
 ├── debug_lambda.py           # Script for running the Lambda function locally
@@ -33,6 +43,39 @@ A template for creating AWS Lambda functions with Python, using Docker images st
 └── README.md                 # This file
 ```
 
+## Testing
+
+This template uses `pytest` and `unittest` for testing.
+
+### Running Tests
+
+To run the unit tests:
+
+```bash
+uv run python -m unittest discover tests
+```
+
+Or if you prefer `pytest`:
+
+```bash
+uv run pytest
+```
+
+## Code Review Challenge
+
+This template is designed to test AI-powered code review tools (like Junie, Copilot, or Qodo). It includes:
+- A modular structure that allows for architectural reviews.
+- Strategic use of type hints.
+- Centralized error handling.
+- Placeholder tests and TODOs to see if they are flagged.
+- A "Manager" pattern that can be critiqued.
+
+### Areas for Reviewers to Focus On:
+1. **Architecture:** Is the `LambdaManager` too heavy? Should the validation logic be more decoupled?
+2. **Security:** Are secrets handled correctly? (Check `_validate_api_key` in `lambda_function.py`).
+3. **Typing:** Are all `Any` types necessary?
+4. **Testing:** Is the test coverage sufficient? Are the mocks appropriate?
+
 ## Getting Started
 
 ### Prerequisites