Skip to content

Added HTTP Authentication#99

Merged
simllll merged 3 commits intosimllll:masterfrom
akifrabbani:master
Jan 23, 2021
Merged

Added HTTP Authentication#99
simllll merged 3 commits intosimllll:masterfrom
akifrabbani:master

Conversation

@akifrabbani
Copy link
Copy Markdown
Contributor

@akifrabbani akifrabbani commented Jan 23, 2021

Added support for simple HTTP based authentication.

{ authentication: 'HTTPAuth', authenticationOptions: { url: 'https://my-website.com/api/backend-login' } }

It will send a JSON POST request to specified URL and expecting status code 200 in order to be passed as successful authentication.

Copy link
Copy Markdown
Owner

@simllll simllll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution, I just reviewed it :-)

Comment thread src/auth/HTTPAuth.ts Outdated
Comment thread src/auth/HTTPAuth.ts Outdated
Comment thread src/auth/HTTPAuth.ts Outdated
@akifrabbani
Copy link
Copy Markdown
Contributor Author

Added validateStatus and eslinted.

@simllll
Copy link
Copy Markdown
Owner

simllll commented Jan 23, 2021

thanks, I will simplify the code after I merged it and remove the try / catch part.

thanks for your contribution!

@simllll simllll merged commit 279541a into simllll:master Jan 23, 2021
@simllll
Copy link
Copy Markdown
Owner

simllll commented Jan 23, 2021

Released in 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants