fix: resolve TypeScript errors in system metrics#2
Merged
simonCatBot merged 2 commits intomasterfrom Mar 27, 2026
Merged
Conversation
- Fix potential undefined values in network stats calculations - Add null checks for CPU data access - Fix GPU metric row props in SystemMetricsDashboard - Use loose null checks (== null) for GPU properties
Replace the overly defensive nested-conditionals + double as-cast with clean optional chaining. cpuData.cpus?.[0]?.speed is readable and correct — no behavioral change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes TypeScript compilation errors that were causing CI failures.
Changes
nameprop, integrated into label)!= null) for GPU properties to handle both null and undefinedTesting
npx tsc --noEmitnow passes without errorsFixes CI workflow failures on master branch.