Skip to content

Future-proof glam version#45

Merged
simonask merged 1 commit intosimonask:mainfrom
rs017991:glamfix
Mar 17, 2024
Merged

Future-proof glam version#45
simonask merged 1 commit intosimonask:mainfrom
rs017991:glamfix

Conversation

@rs017991
Copy link
Copy Markdown
Contributor

See PR #44 for a description of the problem itself and how it is affecting glamour:0.9

This PR is for future-proofing the glamour:0.10 line against premature bumps to future semver-incompatible glam versions.

Since glam:0.26 does not exist yet, this is not a pressing issue for 0.10 in the way that it is for 0.9; as long as a new glamour:0.10.* release is created with this fix before glam:0.26 (or indeed glam:1.0) drops, we'll be fine.

Prevent premature bump to a future semver-incompatible glam version
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.25%. Comparing base (1c3ed22) to head (77818e1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          17       17           
  Lines        4435     4435           
=======================================
  Hits         4402     4402           
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonask
Copy link
Copy Markdown
Owner

Good catch! Yeah, in general this library tends to be tightly coupled with specific minor releases of glam, so this is obviously correct.

The CI failure from cargo-deny is unrelated to this change, so I'll merge this as-is. Thank you for the contribution! 😄

@simonask simonask self-assigned this Mar 17, 2024
@simonask simonask self-requested a review March 17, 2024 06:52
@simonask simonask merged commit 6845fd3 into simonask:main Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants