Future-proof glam version#45
Merged
simonask merged 1 commit intosimonask:mainfrom Mar 17, 2024
rs017991:glamfix
Merged
Conversation
Prevent premature bump to a future semver-incompatible glam version
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 17 17
Lines 4435 4435
=======================================
Hits 4402 4402
Misses 33 33 ☔ View full report in Codecov by Sentry. |
Owner
|
Good catch! Yeah, in general this library tends to be tightly coupled with specific minor releases of glam, so this is obviously correct. The CI failure from |
simonask
approved these changes
Mar 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See PR #44 for a description of the problem itself and how it is affecting
glamour:0.9This PR is for future-proofing the
glamour:0.10line against premature bumps to future semver-incompatibleglamversions.Since
glam:0.26does not exist yet, this is not a pressing issue for0.10in the way that it is for0.9; as long as a newglamour:0.10.*release is created with this fix beforeglam:0.26(or indeedglam:1.0) drops, we'll be fine.